Return "calculated" checksum if requested w/caching #234
+69
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
reviewed
Mar 12, 2021
malmond77
force-pushed
the
cached_calculated_checksum
branch
from
2205fc4
to
2743583
Compare
m-blaha
requested changes
Mar 15, 2021
malmond77
force-pushed
the
cached_calculated_checksum
branch
from
2743583
to
d8d0236
Compare
|
Please, can you also bump the |
If a file is downloaded via librepo (e.g. `dnf install --downloadonly`) then a request to get the checksum via `lr_checksum_fd_compare()` will not work. It'll only return whether the checksum is valid, and not the actual checksum. This is the simple fix. Addresses rpm-software-management#233
malmond77
force-pushed
the
cached_calculated_checksum
branch
from
d8d0236
to
8061564
Compare
|
Thanks! I'll wait for tests to finish and merge it. |
m-blaha
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file is downloaded via librepo (e.g.
dnf install --downloadonly)then a request to get the checksum via
lr_checksum_fd_compare()willnot work. It'll only return whether the checksum is valid, and not the
actual checksum. This is the simple fix.
Addresses #233